Thanks for looking into this.. definitely worthwhile. On Wed, May 31, 2023 at 02:23:59PM +0100, Daniel P. Berrangé wrote: > There are 27 pre-copy live migration scenarios being tested. In all of > these we force non-convergance and run for one iteration, then let it > converge and wait for completion during the second (or following) > iterations. At 3 mbps bandwidth limit the first iteration takes a very > long time (~30 seconds). > > While it is important to test the migration passes and convergance > logic, it is overkill to do this for all 27 pre-copy scenarios. The > TLS migration scenarios in particular are merely exercising different > code paths during connection establishment. > > To optimize time taken, switch most of the test scenarios to run > non-live (ie guest CPUs paused) with no bandwidth limits. This gives > a massive speed up for most of the test scenarios. > > For test coverage the following scenarios are unchanged
Curious how are below chosen? I assume.. > > * Precopy with UNIX sockets this one verifies dirty log. > * Precopy with UNIX sockets and dirty ring tracking ... dirty ring... > * Precopy with XBZRLE ... xbzrle I think needs a diff on old/new, makes sense. > * Precopy with UNIX compress > * Precopy with UNIX compress (nowait) > * Precopy with multifd What about the rest three? Especially for two compression tests. > > On a test machine this reduces execution time from 13 minutes to > 8 minutes. > > Signed-off-by: Daniel P. Berrangé <[email protected]> Thanks, -- Peter Xu
