Hello, On 5/8/23 09:58, Cédric Le Goater wrote:
Hello,This series fixes issues spotted by Coverity and adds a couple of improvements for the machine definition. The first is to offer the capability to define all CS of all SPI controllers without introducing new machine types, using a blockdev on the command line : -blockdev node-name=fmc0,driver=file,filename=./flash.img -device mx66u51235f,addr=0x0,bus=ssi.0,drive=fmc0 instead of using drives which relies on the command line order. Ultimately, we will get rid of drive_get(IF_MTD, ...) but we are not there yet. For this, SSIPeripheral is extended with an "addr" property. A second extension is the introduction of a "uart" machine option to let the user define the default UART device of the machine from the QEMU command line : -M ast2500-evb,uart=uart3 Last, a new "vfp-d32" CPU property is added to ARM CPUs to model FPUs implementing VFPv4 without NEON support and with 16 64-bit FPU registers (and not 32 registers). This is the case for the Cortex A7 of the Aspeed AST2600 SoC. I hope I got it right this time.
I should include these changes in the next aspeed PR. I would have preferred to have R-b tags on some of them, SSI for instance, and also the last patch adding the "vfp-d32" CPU property. Thanks, C.
