On Tue, May 30, 2023 at 01:38:36PM +0200, David Hildenbrand wrote:
> There are no remaining users in the tree, so let's remove it.
>
> Cc: Paolo Bonzini <[email protected]>
> Cc: Richard Henderson <[email protected]>
> Cc: Eduardo Habkost <[email protected]>
> Cc: "Michael S. Tsirkin" <[email protected]>
> Cc: Marcel Apfelbaum <[email protected]>
> Signed-off-by: David Hildenbrand <[email protected]>
This (with previous patches) means any user changing
device-memory-region-size machine property is now broken, right?
How do we know there are no users?
> ---
> hw/i386/pc.c | 19 -------------------
> include/hw/i386/pc.h | 1 -
> 2 files changed, 20 deletions(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 920aa32b53..c4789e2f35 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1646,21 +1646,6 @@ static HotplugHandler
> *pc_get_hotplug_handler(MachineState *machine,
> return NULL;
> }
>
> -static void
> -pc_machine_get_device_memory_region_size(Object *obj, Visitor *v,
> - const char *name, void *opaque,
> - Error **errp)
> -{
> - MachineState *ms = MACHINE(obj);
> - int64_t value = 0;
> -
> - if (ms->device_memory) {
> - value = memory_region_size(&ms->device_memory->mr);
> - }
> -
> - visit_type_int(v, name, &value, errp);
> -}
> -
> static void pc_machine_get_vmport(Object *obj, Visitor *v, const char *name,
> void *opaque, Error **errp)
> {
> @@ -1980,10 +1965,6 @@ static void pc_machine_class_init(ObjectClass *oc,
> void *data)
> object_class_property_set_description(oc, PC_MACHINE_MAX_RAM_BELOW_4G,
> "Maximum ram below the 4G boundary (32bit boundary)");
>
> - object_class_property_add(oc, PC_MACHINE_DEVMEM_REGION_SIZE, "int",
> - pc_machine_get_device_memory_region_size, NULL,
> - NULL, NULL);
> -
> object_class_property_add(oc, PC_MACHINE_VMPORT, "OnOffAuto",
> pc_machine_get_vmport, pc_machine_set_vmport,
> NULL, NULL);
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index c661e9cc80..6c9ad2d132 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -60,7 +60,6 @@ typedef struct PCMachineState {
>
> #define PC_MACHINE_ACPI_DEVICE_PROP "acpi-device"
> #define PC_MACHINE_MAX_RAM_BELOW_4G "max-ram-below-4g"
> -#define PC_MACHINE_DEVMEM_REGION_SIZE "device-memory-region-size"
> #define PC_MACHINE_VMPORT "vmport"
> #define PC_MACHINE_SMBUS "smbus"
> #define PC_MACHINE_SATA "sata"
> --
> 2.40.1
