On 16/5/23 12:58, Paolo Bonzini wrote:
From: John Snow <[email protected]>

Several debian-based tests need the python3-venv dependency as a
consequence of Debian debundling the "ensurepip" module normally
included with Python.

As mkvenv.py stands as of this commit, Debian requires EITHER:

(A) setuptools and pip, or
(B) ensurepip

mkvenv is a few seconds faster if you have setuptools and pip, so
developers should prefer the first requirement. For the purposes of CI,
the time-save is a wash; it's only a matter of who is responsible for
installing pip and when; the timing is about the same.

Arbitrarily, I chose adding ensurepip to the test configuration because
it is normally part of the Python stdlib, and always having it allows us
a more consistent cross-platform environment.

Signed-off-by: John Snow <[email protected]>
Reviewed-by: Daniel P. Berrangé <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
---
  tests/docker/dockerfiles/debian-all-test-cross.docker | 3 ++-
  tests/docker/dockerfiles/debian-hexagon-cross.docker  | 3 ++-
  tests/docker/dockerfiles/debian-riscv64-cross.docker  | 3 ++-
  tests/docker/dockerfiles/debian-tricore-cross.docker  | 3 ++-
  4 files changed, 8 insertions(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>


Reply via email to