On Wed, May 03, 2023 at 07:21:20PM +0200, David Hildenbrand wrote: > Checking whether the memory regions are equal is sufficient: if they are > equal, then most certainly the contained fd is equal.
Looks reasonable to me. I double checked the src of the change and there's no bug report attached either. Maybe just a double safety belt, but definitely Michael will know the best. https://lore.kernel.org/qemu-devel/[email protected]/ > > The whole vhost-user memslot handling is suboptimal and overly > complicated. We shouldn't have to lookup a RAM memory regions we got > notified about in vhost_user_get_mr_data() using a host pointer. But that > requires a bigger rework -- especially an alternative vhost_set_mem_table() > backend call that simply consumes MemoryRegionSections. > > For now, let's just drop vhost_backend_can_merge(). > > Acked-by: Stefan Hajnoczi <[email protected]> > Reviewed-by: Igor Mammedov <[email protected]> > Acked-by: Igor Mammedov <[email protected]> > Signed-off-by: David Hildenbrand <[email protected]> Reviewed-by: Peter Xu <[email protected]> -- Peter Xu
