On Tue, 16 May 2023 at 17:54, Thomas Huth <[email protected]> wrote: > > On 21/04/2023 18.37, Peter Maydell wrote: > > Convert the u2f.txt file to rST, and place it in the right place > > in our manual layout. The old text didn't fit very well into our > > manual style, so the new version ends up looking like a rewrite, > > although some of the original text is preserved: > > > > * the 'building' section of the old file is removed, since we > > generally assume that users have already built QEMU > > * some rather verbose text has been cut back > > * document the passthrough device first, on the assumption > > that's most likely to be of interest to users > > * cut back on the duplication of text between sections > > * format example command lines etc with rST > > > > As it's a short document it seemed simplest to do this all > > in one go rather than try to do a minimal syntactic conversion > > and then clean up the wording and layout. > > > > Signed-off-by: Peter Maydell <[email protected]> > > --- > > docs/system/device-emulation.rst | 1 + > > docs/system/devices/usb-u2f.rst | 93 ++++++++++++++++++++++++++ > > docs/system/devices/usb.rst | 2 +- > > docs/u2f.txt | 110 ------------------------------- > > 4 files changed, 95 insertions(+), 111 deletions(-) > > create mode 100644 docs/system/devices/usb-u2f.rst > > delete mode 100644 docs/u2f.txt > > I'm not an expert at all in this area, but your changes look sane to me, so: > > Reviewed-by: Thomas Huth <[email protected]>
Thanks for the review; I'll take this via my target-arm tree since I'm planning a pullreq anyway. -- PMM
