On 14/05/2023 22.31, Paolo Bonzini wrote:
Il ven 12 mag 2023, 14:41 Thomas Huth <[email protected]
<mailto:[email protected]>> ha scritto:
These tests rely on a default NIC to be available. Skip them if we
used the "--without-default-devices" configure option.
Signed-off-by: Thomas Huth <[email protected] <mailto:[email protected]>>
This is the only patch I have some qualms about, because it reduces coverage
in legitimate setups where the default NIC _is_ included in the binary.
Still a lot better than before, but please add a FIXME here.
Ok, will do.
We can perhaps
try to use QMP to check if the machines have a usable default NIC, and if
not skip the test, but this should not block the bulk of your work from
being merged.
I'm currently not aware of a way to query the default NIC via QMP, so this
might need some extensions there ... but I'll keep it in mind.
The alternative would be to hard-code the default NICs for each architecture
in the tests again and check for the availability with that hard-coded list
... but that's also ugly, I think.
So, apart from this issue, series
Acked-by: Paolo Bonzini <[email protected]>
Thanks!
Thomas
