On 5/12/2023 4:42 PM, Alex Bennée wrote: > > "Wu, Fei" <[email protected]> writes: > >> On 4/22/2023 12:42 AM, Alex Bennée wrote: >>> >>> Fei Wu <[email protected]> writes: >>> >>>> This patch series were done by Vanderson and Alex originally in 2019, I >>>> (Fei Wu) rebased them on latest upstream from: >>>> https://github.com/stsquad/qemu/tree/tcg/tbstats-and-perf-v10 >>>> and send out this review per Alex's request, I will continue to address >>>> any future review comments here. As it's been a very long time and there >>>> are lots of conflicts during rebase, it's my fault if I introduce any >>>> problems during the process. >>> >>> Hi Fei, >>> >>> Thanks for picking this up. I can confirm that this applies cleanly to >>> master and I have kicked the tyres and things still seem to work. I'm >>> not sure if I can provide much review on code I wrote but a few things >>> to point out: >>> >> Hi Alex, >> >> There are several new files added, should I put your name as their >> maintainer? Also, should I signed-off these patches or not, definitely >> the original signed-offs will be kept. > > I assume they would just become part of the accel/tcg stuff rather than > be maintained as a separate subsystem. > ok. I see ./scripts/checkpatch.pl reports some warnings as follows:
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > For sign-offs you should keep the original authors and add your own. > Each s-o-b is a statement by the person working with the code that they > are "legally okay to contribute this and happy for it to go into QEMU". > So it is totally normal for work that goes through several trees before > being merged to have multiple sign-offs. When the maintainer creates > their pull request they will add theirs as well. > Got it, thank you. Fei.
