On 10.05.23 15:18, Juan Quintela wrote:
Vladimir Sementsov-Ogievskiy <[email protected]> wrote:
On 09.05.23 21:42, Juan Quintela wrote:
"Zhang, Chen" <[email protected]> wrote:
-----Original Message-----
From: Vladimir Sementsov-Ogievskiy <[email protected]>
Sent: Saturday, April 29, 2023 3:49 AM
To: [email protected]
Cc: [email protected]; [email protected]; Zhang, Chen
<[email protected]>; [email protected]; Paolo Bonzini
<[email protected]>; Marc-André Lureau
<[email protected]>; Daniel P. Berrangé
<[email protected]>; Thomas Huth <[email protected]>; Philippe
Mathieu-Daudé <[email protected]>; Jason Wang <[email protected]>
Subject: [PATCH v4 04/10] configure: add --disable-colo-proxy option
Add option to not build filter-mirror, filter-rewriter and colo-compare when
they are not needed.
Typo: This patch still build the filter-mirror/filter-redirector in
filter-mirror.c.
Please remove the "filter-mirror" here.
Other code look good to me.
Vladimir, I was doing this myself, with the bit attached.
But then I noticed that one needs to also disable
tests/qtest/test-filter-mirror and test-filter-rewriter.
Hmm, but we decided not touch filter-mirror in this patch, only filter-rewriter.
And there is no tests/qtest/test-filter-rewriter test.
Can you resend with that fixed? Or I am missing something more
fundamental.
Thanks, Juan.
--- a/net/meson.build
+++ b/net/meson.build
@@ -1,13 +1,10 @@
softmmu_ss.add(files(
'announce.c',
'checksum.c',
- 'colo-compare.c',
- 'colo.c',
'dump.c',
'eth.c',
'filter-buffer.c',
'filter-mirror.c',
- 'filter-rewriter.c',
'filter.c',
'hub.c',
'net-hmp-cmds.c',
@@ -19,6 +16,16 @@ softmmu_ss.add(files(
'util.c',
))
+if get_option('replication').allowed() or \
+ get_option('colo_proxy').allowed()
+ softmmu_ss.add(files('colo-compare.c'))
+ softmmu_ss.add(files('colo.c'))
+endif
+
+if get_option('colo_proxy').allowed()
+ softmmu_ss.add(files('filter-rewriter.c'))
+endif
+
softmmu_ss.add(when: 'CONFIG_TCG', if_true: files('filter-replay.c'))
This is the change needed, right?
No, we decided to keep filter-mirror as is.
Ok. Anyways, this bit needs an ACK from Network Maintainer or go
through their tree.
I think r-b from Zhang is enough, he is maintainer of COLO Proxy, which
includes filter-rewriter.
(anyway, I'll resend the rest of the series when you PULL request merged)
--
Best regards,
Vladimir
