On [2023 May 08] Mon 09:58:48, Cédric Le Goater wrote: > As mentioned in docs/devel/style.rst "Automatic memory deallocation": > > * Variables declared with g_auto* MUST always be initialized, > otherwise the cleanup function will use uninitialized stack memory > > This avoids QEMU to coredump when running the "hash test" command > under Zephyr. > > Cc: Steven Lee <[email protected]> > Cc: Joel Stanley <[email protected]> > Fixes: c5475b3f9a ("hw: Model ASPEED's Hash and Crypto Engine") > Reviewed-by: Alex Bennée <[email protected]> > Reviewed-by: Thomas Huth <[email protected]> > Message-Id: <[email protected]> > Signed-off-by: Cédric Le Goater <[email protected]>
Reviewed-by: Francisco Iglesias <[email protected]> > --- > hw/misc/aspeed_hace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c > index 12a761f1f5..b07506ec04 100644 > --- a/hw/misc/aspeed_hace.c > +++ b/hw/misc/aspeed_hace.c > @@ -189,7 +189,7 @@ static void do_hash_operation(AspeedHACEState *s, int > algo, bool sg_mode, > bool acc_mode) > { > struct iovec iov[ASPEED_HACE_MAX_SG]; > - g_autofree uint8_t *digest_buf; > + g_autofree uint8_t *digest_buf = NULL; > size_t digest_len = 0; > int niov = 0; > int i; > -- > 2.40.0 > >
