On Thu, May 04, 2023 at 08:35:53AM +0200, Thomas Huth wrote:
> On 03/05/2023 16.55, Ani Sinha wrote:
> > mformat and xorriso tools are needed by biosbits avocado tests. This
> > patchset
> > adds those two tools in the docker container images.
>
> tests/qtest/cdrom-test.c already uses genisoimage to create ISO images, and
> the containers already have that tool installed. Could you maybe switch the
> biosbits test to use that tool? Or the other way round? ... at least having
> two tools to create ISO images in our containers sounds IMHO excessive.
It looks like this series wasn't tested, because it doesn't even install
the alpine image:
ERROR: unable to select packages:
cdrkit-1.1.11-r3:
conflicts: xorriso-1.5.4-r2[cmd:mkisofs=1.1.11-r3]
satisfies: world[cdrkit]
xorriso-1.5.4-r2:
conflicts: cdrkit-1.1.11-r3[cmd:mkisofs=1.5.4-r2]
satisfies: world[xorriso]
We definitely need to have either biosbits or cdrom-test.c changed to
use the same tool. We can't be requiring deps that are conflicting at
install time.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
