On 5/3/23 11:12, Alex Bennée wrote:
From: Fabiano Rosas<[email protected]>
This machine hardcodes the creation of the interrupt controller, so
make sure the dependency is explicitly described in the Kconfig.
gicv3_init_cpuif is used unconditionally by arm_gic_realize in
hw/intc/arm_gicv3.c, so right now the separation between GICV3 and
GICV3_TCG is useless.
That said, using "default y" is wrong. The correct definition in
hw/intc/Kconfig for these should be:
config ARM_GIC
bool
select MSI_NONBROKEN
select ARM_GICV3_TCG # if TCG
select ARM_GIC_KVM if KVM
config ARM_GICV3_TCG
bool
config ARM_GIC_KVM
bool
(where the "if TCG" is incorrect right now as explained above).
Paolo
Signed-off-by: Fabiano Rosas<[email protected]>
Reviewed-by: Peter Maydell<[email protected]>
Signed-off-by: Alex Bennée<[email protected]>
Message-Id:<[email protected]>
---
hw/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index cec7898bb7..0cce0b8d5b 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -252,6 +252,7 @@ config SBSA_REF
select PL061 # GPIO
select USB_EHCI_SYSBUS
select WDT_SBSA
+ select ARM_GICV3_TCG
