On Wed, May 03, 2023 at 10:43:16AM -0500, Eric Blake wrote: > On Tue, May 02, 2023 at 05:11:19PM -0400, Stefan Hajnoczi wrote: > > Most export types install BlockDeviceOps pointers. It is easy to forget > > to remove them because that happens automatically via the "drive" qdev > > property in hw/ but not block/export/. > > > > Put blk_set_dev_ops(blk, NULL, NULL) calls in the core export.c code so > > the export types don't need to remember. > > > > This fixes the nbd and vhost-user-blk export types. > > > > Fixes: fd6afc501a01 ("nbd/server: Use drained block ops to quiesce the > > server") > > Fixes: ca858a5fe94c ("vhost-user-blk-server: notify client about disk > > resize") > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > > --- > > block/export/export.c | 2 ++ > > block/export/vduse-blk.c | 1 - > > 2 files changed, 2 insertions(+), 1 deletion(-) > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > I'm happy to add this through my NBD queue.
Sure, go ahead! Stefan
signature.asc
Description: PGP signature