Re: [PATCH v2 01/16] migration: Create migrate_rdma()

[Juan Quintela]

Daniel P. Berrangé <berra...@redhat.com> wrote:
> On Wed, May 03, 2023 at 03:18:32PM +0200, Juan Quintela wrote:
>> Helper to say if we are doing a migration over rdma.
>
> Is the "MigrationState" allocated freshly for every incoming
> or outgoing migration ?  If it is reused, then something
> needs to set 's->rdma_migration = false' in non-RDMA code
> paths.

for (i = 0; i < 1000; i++)
    printf("never trust memory, check the code.\n");

You are right, the function that we call is:
migrate_init()

but we clear each statistic by hand, not a memset().

And now I have to review that we are not missing any other field to
reset.

Thanks, Juan.