Vladimir Sementsov-Ogievskiy <[email protected]> wrote: > On 28.04.23 10:33, Juan Quintela wrote: >> Vladimir Sementsov-Ogievskiy <[email protected]> wrote: >>> Add option to not build filter-mirror, filter-rewriter and >>> colo-compare when they are not needed. >>> >>> There could be more agile configuration, for example add separate >>> options for each filter, but that may be done in future on demand. The >>> aim of this patch is to make possible to disable the whole COLO Proxy >>> subsystem. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]> >> As you have arrived to an agreement about what to do with >> filter-rewriter, the rest of the patch is ok with me. > > You mean filter-mirror, precisely this change to the patch: > > @@ -22,7 +22,7 @@ if get_option('replication').allowed() or \ > endif > if get_option('colo_proxy').allowed() > - softmmu_ss.add(files('filter-mirror.c', 'filter-rewriter.c')) > + softmmu_ss.add(files('filter-rewriter.c')) > endif > softmmu_ss.add(when: 'CONFIG_TCG', if_true: files('filter-replay.c')) > > ?
Oops, yes. >> Reviewed-by: Juan Quintela <[email protected]> >>
