On 2012-02-01 08:29, Paolo Bonzini wrote:
> On 01/31/2012 09:49 PM, Anthony Liguori wrote:
>>>
>>> + DEFINE_PROP_HEX32("iobase", PCSpkState, iobase, -1),
>>> + DEFINE_PROP_PTR("pit", PCSpkState, pit),
>>
>> Please don't introduce a pointer property here. They cannot be used in
>> a meaningful way in qdev. Why not register a link<TYPE_PIT> in
>> instance_init?
>
> I'm going to clean this up, you can leave the PTR for now.
OK, will then ship v4 with this property still in place and count on you.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
