> -----Original Message----- > From: Akihiko Odaki <[email protected]> > Sent: Friday, 14 April 2023 13:37 > Cc: Sriram Yagnaraman <[email protected]>; Jason Wang > <[email protected]>; Dmitry Fleytman <[email protected]>; > Michael S. Tsirkin <[email protected]>; Alex Bennée <[email protected]>; > Philippe Mathieu-Daudé <[email protected]>; Thomas Huth > <[email protected]>; Wainer dos Santos Moschetta > <[email protected]>; Beraldo Leal <[email protected]>; Cleber Rosa > <[email protected]>; Laurent Vivier <[email protected]>; Paolo Bonzini > <[email protected]>; [email protected]; Akihiko Odaki > <[email protected]> > Subject: [PATCH 05/40] igb: Do not require CTRL.VME for tx VLAN tagging > > While the datasheet of e1000e says it checks CTRL.VME for tx VLAN tagging, > igb's datasheet has no such statements. It also says for > "CTRL.VLE": > > This register only affects the VLAN Strip in Rx it does not have any > > influence in the Tx path in the 82576. > (Appendix A. Changes from the 82575) > > There is no "CTRL.VLE" so it is more likely that it is a mistake of CTRL.VME. > > Fixes: fba7c3b788 ("igb: respect VMVIR and VMOLR for VLAN") > Signed-off-by: Akihiko Odaki <[email protected]> > --- > hw/net/igb_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
Reviewed-by: Sriram Yagnaraman <[email protected]>
