Re: [PATCH v2 15/25] target/ppc: Avoid tcg_const_* in vmx-impl.c.inc

[Daniel Henrique Barboza]

On 3/7/23 15:34, Richard Henderson wrote:

All remaining uses are strictly read-only.

Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
---

Reviewed-by: Daniel Henrique Barboza <danielhb...@gmail.com>

Cc: Daniel Henrique Barboza <danielhb...@gmail.com>
Cc: Cédric Le Goater <c...@kaod.org>
Cc: David Gibson <da...@gibson.dropbear.id.au>
Cc: Greg Kurz <gr...@kaod.org>
Cc: qemu-...@nongnu.org
---
  target/ppc/translate/vmx-impl.c.inc | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/target/ppc/translate/vmx-impl.c.inc 
b/target/ppc/translate/vmx-impl.c.inc
index ca27c11d87..112233b541 100644
--- a/target/ppc/translate/vmx-impl.c.inc
+++ b/target/ppc/translate/vmx-impl.c.inc
@@ -1624,7 +1624,7 @@ static void glue(gen_, name)(DisasContext *ctx)           
              \
              gen_exception(ctx, POWERPC_EXCP_VPU);                       \
              return;                                                     \
          }                                                               \
-        uimm = tcg_const_i32(UIMM5(ctx->opcode));                       \
+        uimm = tcg_constant_i32(UIMM5(ctx->opcode));                    \
          rb = gen_avr_ptr(rB(ctx->opcode));                              \
          rd = gen_avr_ptr(rD(ctx->opcode));                              \
          gen_helper_##name(cpu_env, rd, rb, uimm);                       \
@@ -1965,7 +1965,7 @@ static void gen_vsldoi(DisasContext *ctx)
      ra = gen_avr_ptr(rA(ctx->opcode));
      rb = gen_avr_ptr(rB(ctx->opcode));
      rd = gen_avr_ptr(rD(ctx->opcode));
-    sh = tcg_const_i32(VSH(ctx->opcode));
+    sh = tcg_constant_i32(VSH(ctx->opcode));
      gen_helper_vsldoi(rd, ra, rb, sh);
  }

@@ -2575,7 +2575,7 @@ static void gen_##op(DisasContext *ctx) \

      rb = gen_avr_ptr(rB(ctx->opcode));              \
      rd = gen_avr_ptr(rD(ctx->opcode));              \
                                                      \
-    ps = tcg_const_i32((ctx->opcode & 0x200) != 0); \
+    ps = tcg_constant_i32((ctx->opcode & 0x200) != 0); \
                                                      \
      gen_helper_##op(cpu_crf[6], rd, ra, rb, ps);    \
  }
@@ -2594,7 +2594,7 @@ static void gen_##op(DisasContext *ctx)             \
      rb = gen_avr_ptr(rB(ctx->opcode));              \
      rd = gen_avr_ptr(rD(ctx->opcode));              \
                                                      \
-    ps = tcg_const_i32((ctx->opcode & 0x200) != 0); \
+    ps = tcg_constant_i32((ctx->opcode & 0x200) != 0); \
                                                      \
      gen_helper_##op(cpu_crf[6], rd, rb, ps);        \
  }
@@ -2726,7 +2726,7 @@ static void gen_##op(DisasContext *ctx)       \
      }                                         \
      ra = gen_avr_ptr(rA(ctx->opcode));        \
      rd = gen_avr_ptr(rD(ctx->opcode));        \
-    st_six = tcg_const_i32(rB(ctx->opcode));  \
+    st_six = tcg_constant_i32(rB(ctx->opcode));  \
      gen_helper_##op(rd, ra, st_six);          \
  }