> -----Original Message----- > From: Anton Johansson <[email protected]> > Sent: Friday, February 24, 2023 7:24 AM > To: Taylor Simpson <[email protected]>; [email protected] > Cc: [email protected]; [email protected]; [email protected]; Brian Cain > <[email protected]>; Matheus Bernardino (QUIC) > <[email protected]> > Subject: Re: [PATCH v5 13/14] Hexagon (target/hexagon) Reduce > manipulation of slot_cancelled > > On 1/31/23 23:56, Taylor Simpson wrote: > > /* Called during packet commit when there are two scalar stores */ > > -void HELPER(probe_pkt_scalar_store_s0)(CPUHexagonState *env, int > > mmu_idx) > > +void HELPER(probe_pkt_scalar_store_s0)(CPUHexagonState *env, int > > +args) > > { > > - probe_store(env, 0, mmu_idx); > > + int mmu_idx = args & 0x3; > > + bool is_predicated = (args >> 2) & 1; > > + probe_store(env, 0, mmu_idx, is_predicated); > > } > Can we use bitmasks for the fields of args?
OK, but better to use "hw/registerfields.h". Thanks, Taylor
