Hi On Tue, Feb 28, 2023 at 7:55 PM Eric Blake <[email protected]> wrote:
> On Tue, Feb 07, 2023 at 06:25:32PM +0400, [email protected] > wrote: > > From: Marc-André Lureau <[email protected]> > > > > The generated code doesn't quite handle the conditional arguments. > > For example, 'bar' in 'test-if-cmd' is not correctly surrounded by #if > > conditions. See generated code in qmp_marshal_test_if_cmd(). > > > > Note that if there are multiple optional arguments at the last position, > > there might be compilation issues due to extra comas. I left an assert > > and FIXME for later. > > Would it be simpler to just state that ALL commands that want to use > optional arguments must use a boxed type? Then the function signature > is simple (a single boxed type), and the logic of the optional > parameter is now contained within the type rather than within the > function signature. > > Possibly, but I would prefer if we leave that as a FIXME, because review rate isn't quite fast, and it delays other patches that are pending for months already ...
