Hi Eric,
On Thu, Feb 16, 2023 at 12:32:21PM +0100, Eric Auger wrote:
> > SMMUTransTableInfo *tt;
> > SMMUTransCfg *cfg = NULL;
> > + uint8_t granule_sz, tsz;
> > IOMMUTLBEntry entry = {
> > .target_as = &address_space_memory,
> > .iova = addr,
> > @@ -764,21 +767,40 @@ static IOMMUTLBEntry
> > smmuv3_translate(IOMMUMemoryRegion *mr, hwaddr addr,
> > goto epilogue;
> > }
> >
> > - tt = select_tt(cfg, addr);
> maybe we shall adapt select_tt for S2 instead of using temp? I know
> there is a single range on S2 but well, use tt[0]?
We can adapt select_tt for S2, but we would need to have an instance
of SMMUTransTableInfo in SMMUS2Cfg instead of having vttb,tsz..
inlined, as the function returns a pointer to the SMMUTransTableInfo.
I don’t think we can reuse tt[0], as this would change when we support
nesting, so I think we just isolate s1 and s2 from the beginning.
> > - if (!tt) {
> > - if (cfg->record_faults) {
> > - event.type = SMMU_EVT_F_TRANSLATION;
> > - event.u.f_translation.addr = addr;
> > - event.u.f_translation.rnw = flag & 0x1;
> > + if (STAGE1_SUPPORTED(s->features)) {
> maybe check the enable state instead.
Yes, if stage-1 is not enabled, tt might not be valid, I will update it.
Thanks,
Mostafa
