Re: [PATCH] Adding new machine Yosemitev2 in QEMU

[Philippe Mathieu-Daudé]

Hi Pasupathi,

On 16/2/23 11:48, Karthikeyan Pasupathi wrote:

Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1...@gmail.com>
---
  hw/arm/aspeed.c        | 38 ++++++++++++++++++++++++++++++++++++++
  hw/arm/aspeed_eeprom.c | 23 +++++++++++++++++++++++
  hw/arm/aspeed_eeprom.h |  3 +++
  3 files changed, 64 insertions(+)

+static void yosemitev2_bmc_i2c_init(AspeedMachineState *bmc)
+{
+    AspeedSoCState *soc = &bmc->soc;
+
+    I2CBus *i2c[16];
+
+    for (int i = 0; i < 16; i++) {
+        i2c[i] = aspeed_i2c_get_bus(&soc->i2c, i);
+    }
+
+    at24c_eeprom_init(i2c[4], 0x51, 128 * KiB);
+
+    at24c_eeprom_init_rom(i2c[8], 0x51, 128 * KiB, fbyv2_bmc_fruid,
+                          fbyv2_bmc_fruid_len);

This can be simplified as:

at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 4), 0x51, 128 * KiB);
at24c_eeprom_init_rom(aspeed_i2c_get_bus(&soc->i2c, 8), 0x51, 128 * KiB,
                      fbyv2_bmc_fruid, fbyv2_bmc_fruid_len);

+}