Re: [PATCH 19/20] hw/ide/piix: Pass Error* to pci_piix_init_ports() for better error msg

[Richard Henderson]

On 2/15/23 01:27, Philippe Mathieu-Daudé wrote:

-    rc = pci_piix_init_ports(d);
-    if (rc) {
-        error_setg_errno(errp, -rc, "Failed to realize %s",
-                         object_get_typename(OBJECT(dev)));
+    if (!pci_piix_init_ports(d, errp)) {
+        return;
      }

The if is unnecessary.

Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~