On Tue, Feb 07, 2023 at 06:31:53PM +0000, Dr. David Alan Gilbert wrote:
> * Philippe Mathieu-Daudé ([email protected]) wrote:
> > On 7/2/23 18:49, Dr. David Alan Gilbert (git) wrote:
> > > From: "Dr. David Alan Gilbert" <[email protected]>
> > >
> > > In bad9c5a5166fd5e3a892b7b0477cf2f4bd3a959a I fixed the virito-rng-pci
> >
> > Typo "virtio-rng-pci".
>
> I've made that typo SO many times...
Add this in .vimrc
ab virito virtio
and never make this mistake again ... as long as you use vim ;)
> > > migration compatibility, but it was discovered that we also need to fix
> > > the other aliases of the device for the transitional cases.
> > >
> > > Fixes: 9ea02e8f1 ('virtio-rng-pci: Allow setting nvectors, so we can use
> > > MSI-X')
> > > bz: https://bugzilla.redhat.com/show_bug.cgi?id=2162569
> > > Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> > > ---
> > > hw/core/machine.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/hw/core/machine.c b/hw/core/machine.c
> > > index b5cd42cd8c..4627b274d9 100644
> > > --- a/hw/core/machine.c
> > > +++ b/hw/core/machine.c
> > > @@ -49,6 +49,8 @@ const size_t hw_compat_7_2_len =
> > > G_N_ELEMENTS(hw_compat_7_2);
> > > GlobalProperty hw_compat_7_1[] = {
> > > { "virtio-device", "queue_reset", "false" },
> > > { "virtio-rng-pci", "vectors", "0" },
> > > + { "virtio-rng-pci-transitional", "vectors", "0" },
> > > + { "virtio-rng-pci-non-transitional", "vectors", "0" },
> >
> > Ouch :(
> >
> > Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
>
> Thanks!
>
> Dave
>
> >
> > > };
> > > const size_t hw_compat_7_1_len = G_N_ELEMENTS(hw_compat_7_1);
> >
> --
> Dr. David Alan Gilbert / [email protected] / Manchester, UK
