On 06/02/2023 15.08, Fabiano Rosas wrote:
The i440fx machines uses the e1000 adapter as the default when no
other network card is configured.

Move the E1000_PCI entry in Kconfig from 'imply' to 'select' to avoid
the following situation:

./qemu-system-i386 -machine pc-i440fx-8.0
qemu-system-i386: Unsupported NIC model: e1000

Signed-off-by: Fabiano Rosas <[email protected]>
---
  hw/i386/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index 8e59cb6634..343783ea3e 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -66,7 +66,6 @@ config PC_ACPI
config I440FX
      bool
-    imply E1000_PCI
      imply VMPORT
      imply VMMOUSE
      select ACPI_PIIX4
@@ -78,6 +77,7 @@ config I440FX
      select DIMM
      select SMBIOS
      select FW_CFG_DMA
+    select E1000_PCI

Reviewed-by: Thomas Huth <[email protected]>


Reply via email to