Fiona Ebner <[email protected]> wrote: > upon errors. As the documentation in include/io/channel.h states, only > -1 and QIO_CHANNEL_ERR_BLOCK should be returned upon error. Other > values have the potential to confuse the call sites. > > error_setg is used rather than error_setg_errno, because there are > certain code paths where -1 (as a non-errno) is propagated up (e.g. > starting from qemu_rdma_block_for_wrid or qemu_rdma_post_recv_control) > all the way to qio_channel_rdma_{readv,writev}. > > Similar to a216ec85b7 ("migration/channel-block: fix return value for > qio_channel_block_{readv,writev}"). > > Suggested-by: Zhang Chen <[email protected]> > Signed-off-by: Fiona Ebner <[email protected]>
Reviewed-by: Juan Quintela <[email protected]> queued.
