Hi
On Tue, Jan 24, 2023 at 7:48 AM Anton Kochkov <[email protected]> wrote:
>
> This is necessary for Muon build system compatibility and
> prevents the following error:
>
> meson.build:4:8: error module 'i18n' is unimplemented,
> If you would like to make your build files portable to muon,
> use `import('i18n', required: false)`,
> and then check the .found() method before use.
> 4 | i18n.gettext(meson.project_name(),
> ^
> qemu/meson.build:3640:3: error in function subdir()
> 3640 | subdir('po')
> ^
>
> Signed-off-by: Anton Kochkov <[email protected]>
> ---
> po/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/po/meson.build b/po/meson.build
> index a863f0575f..f7be95cf5f 100644
> --- a/po/meson.build
> +++ b/po/meson.build
> @@ -1,4 +1,4 @@
> -i18n = import('i18n')
> +i18n = import('i18n', required: false)
It should probably be "required: get_option('gettext')" instead,...
>
> if find_program('xgettext', required: get_option('gettext')).found()
> i18n.gettext(meson.project_name(),
..what if you move the import below here?
Fwiw, the i18n module is not the most complex. It may be a good idea
to try implementing it..
Impressive that muon can handle qemu though! I tried "configure
--meson=muon" but that didn't go far, how do you test it?
--
Marc-André Lureau
