On 1/19/23 03:54, Fabiano Rosas wrote:
The migration tests are currently broken for an aarch64 host because
the tests pass no 'machine' and 'cpu' options on the QEMU command
line. Most other architectures define a default value in QEMU for
these options, but arm does not.
Add these options to the test class in case the test is being executed
in an aarch64 host.
Signed-off-by: Fabiano Rosas <[email protected]>
---
Don't we want to run migration tests for all the built targets? A
cleaner approach would be to just subclass Migration for each
archictecture like in boot_linux.py.
---
tests/avocado/migration.py | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <[email protected]>
@@ -62,7 +72,6 @@ def _get_free_port(self):
self.cancel('Failed to find a free port')
return port
-
def test_migration_with_tcp_localhost(self):
dest_uri = 'tcp:localhost:%u' % self._get_free_port()
self.do_migrate(dest_uri)
Unrelated change. Also, I think there's some python style guide that suggests 2 lines
between functions and classes.
r~
