On 16.01.2012, at 14:59, Hannes Reinecke wrote:
> On 01/16/2012 02:39 PM, Anthony Liguori wrote:
>> On 01/13/2012 10:54 AM, Andreas Färber wrote:
>>> Am 13.01.2012 12:19, schrieb Hannes Reinecke:
>>>> + if (desc) {
>>>> + trace_megasas_readl_reg("mmio", desc, retval);
>>>> + } else {
>>>> + trace_megasas_readl("mmio", addr, retval);
>>>> + }
>>>
>>> Drop _reg version?
>>>
>>> Didn't review the SCSI bits. Patch is pretty large, too. ;)
>>
>> I have the same thought but it looks to be large because of the
>> header and tracing file. I didn't see an obvious place to break it up.
>>
>> Although Hannes, if there is a way to break it up, that would
>> certainly help review.
>>
> Hmm. Yes, I could try to split it up by removing the trace hooks and
> add them with a later patch.
>
> But the emulation itself would be pretty pointless to split up ...
You could add the header in a separate first patch :)
Alex
