> -----Original Message-----
> From: Matheus Tavares Bernardino <[email protected]>
> Sent: Friday, January 13, 2023 7:39 AM
> To: [email protected]
> Cc: Taylor Simpson <[email protected]>; Brian Cain
> <[email protected]>; [email protected]
> Subject: [PATCH 2/2] Hexagon (decode): look for pkts with multiple insns at
> the same slot
> 
> Each slot in a packet can be assigned to at most one instruction.
> Although the assembler generally ought to enforce this rule, we better be
> safe than sorry and also do some check to properly throw an "invalid packet"
> exception on wrong slot assignments.
> 
> This should also make it easier to debug possible future errors caused by
> missing updates to `find_iclass_slots()` rules in target/hexagon/iclass.c.
> 
> Signed-off-by: Matheus Tavares Bernardino <[email protected]>
> ---
>  target/hexagon/decode.c           | 30 +++++++++++++++++++++++++++---
>  tests/tcg/hexagon/Makefile.target | 10 ++++++++++
> tests/tcg/hexagon/invalid_slots.c | 29 +++++++++++++++++++++++++++++
>  3 files changed, 66 insertions(+), 3 deletions(-)  create mode 100644
> tests/tcg/hexagon/invalid_slots.c

Reviewed-by: Taylor Simpson <[email protected]>


Reply via email to