* David Hildenbrand ([email protected]) wrote: > On 12.01.23 17:58, Dr. David Alan Gilbert wrote: > > * David Hildenbrand ([email protected]) wrote: > > > Let's move more code into vmstate_save(), reducing code duplication and > > > preparing for reuse of vmstate_save() in qemu_savevm_state_setup(). We > > > have to move vmstate_save() to make the compiler happy. > > > > > > We'll now also trace from qemu_save_device_state(). > > > > Mostly OK, but.. > > > > > Signed-off-by: David Hildenbrand <[email protected]> > > > --- > > > migration/savevm.c | 79 ++++++++++++++++++++++------------------------ > > > > Doesn't this also need to upate trace-events? > > The existing trace events from > qemu_savevm_state_complete_precopy_non_iterable() are simply moved to > vmstate_save(), so qemu_save_device_state() will implicitly use them. > > So no update should be needed (no new events), or am I missing something?
Aren't you losing the trace_savevm_state_setup() trace? Dave > Thanks! > > > -- > Thanks, > > David / dhildenb > -- Dr. David Alan Gilbert / [email protected] / Manchester, UK
