On Wed, 11 Jan 2023 at 09:14, Paolo Bonzini <[email protected]> wrote: > > On 1/10/23 11:53, Peter Maydell wrote: > > On Tue, 10 Jan 2023 at 09:33, Paolo Bonzini <[email protected]> wrote: > >> > >> A handful of header files in QEMU are wrapped with extern "C" blocks. > >> These are not necessary: there are C++ source files anymore in QEMU, > >> and even where there were some, they did not include most of these > >> files anyway. > > > > Any reason not to also take out the extern "C" block in osdep.h > > and the uses of QEMU_EXTERN_C ? > > qemu/osdep.h is still included by the C++ sources in qga/vss-win32.
If anything C++ still includes osdep.h then you can't remove the handling of this from os-win32.h and os-posix.h, because those files are included from osdep.h. thanks -- PMM
