Thank you for your reply. My first patch is already merged as a commit 75ac231c67cdb13f0609943fab5499963858b587 by Paolo. But it seems my second patch isn't merged yet. If Paolo or someone else plans to merge it, it's no problem. This is just a ping to the second patch. Not a new fix.
----- List of my patches. ----- The below is my first patch already merged as a commit 75ac231c67cdb13f0609943fab5499963858b587 by Paolo. https://patchew.org/QEMU/ty0pr0101mb4285f637209075c9f65fcda6a4...@ty0pr0101mb4285.apcprd01.prod.exchangelabs.com/ The below is my second patch. https://patchew.org/QEMU/ty0pr0101mb42855925d8414e4773d6fa36a4...@ty0pr0101mb4285.apcprd01.prod.exchangelabs.com/ The below is my second patch fixed according to Richard's review. https://patchew.org/QEMU/ty0pr0101mb4285923fbe9ad97ce832d95ba4...@ty0pr0101mb4285.apcprd01.prod.exchangelabs.com/ The below is ping to fixed second patch. This is just a ping. Not a new fix. https://patchew.org/QEMU/ty0pr0101mb4285ad60fe3976f1ad5c6d02a4...@ty0pr0101mb4285.apcprd01.prod.exchangelabs.com/ ------------------------------- Thanks. Taisei Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows From: Alex Bennée<mailto:[email protected]> Sent: Saturday, January 7, 2023 7:16 PM To: TaiseiIto<mailto:[email protected]> Cc: [email protected]<mailto:[email protected]>; [email protected]<mailto:[email protected]>; Paolo Bonzini<mailto:[email protected]> Subject: Re: [PATCH v2] [PING] target/i386/gdbstub: Fix a bug about order of FPU stack in 'g' packets. TaiseiIto <[email protected]> writes: > This is a ping to the patch below. > > https://patchew.org/QEMU/ty0pr0101mb42855925d8414e4773d6fa36a4...@ty0pr0101mb4285.apcprd01.prod.exchangelabs.com/ > > Before this commit, when GDB attached an OS working on QEMU, order of FPU > stack registers printed by GDB command 'info float' was wrong. There was a > bug causing the problem in 'g' packets sent by QEMU to GDB. The packets have > values of registers of machine emulated by QEMU containing FPU stack > registers. There are 2 ways to specify a x87 FPU stack register. The first > is specifying by absolute indexed register names (R0, ..., R7). The second > is specifying by stack top relative indexed register names (ST0, ..., ST7). > Values of the FPU stack registers should be located in 'g' packet and be > ordered by the relative index. But QEMU had located these registers ordered > by the absolute index. After this commit, when QEMU reads registers to make > a 'g' packet, QEMU specifies FPU stack registers by the relative index. > Then, the registers are ordered correctly in the packet. As a result, GDB, > the packet receiver, can print FPU stack registers in the correct order. > > Signed-off-by: TaiseiIto <[email protected]> > --- > target/i386/gdbstub.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/target/i386/gdbstub.c b/target/i386/gdbstub.c > index c3a2cf6f28..786971284a 100644 > --- a/target/i386/gdbstub.c > +++ b/target/i386/gdbstub.c > @@ -121,7 +121,9 @@ int x86_cpu_gdb_read_register(CPUState *cs, GByteArray > *mem_buf, int n) > return gdb_get_reg32(mem_buf, env->regs[gpr_map32[n]]); > } > } else if (n >= IDX_FP_REGS && n < IDX_FP_REGS + 8) { > - floatx80 *fp = (floatx80 *) &env->fpregs[n - IDX_FP_REGS]; > + int st_index = n - IDX_FP_REGS; > + int r_index = (st_index + env->fpstt) % 8; > + floatx80 *fp = &env->fpregs[r_index].d; > int len = gdb_get_reg64(mem_buf, cpu_to_le64(fp->low)); > len += gdb_get_reg16(mem_buf, cpu_to_le16(fp->high)); > return len; I'm sorry I though Paolo had already grabbed this, or is this a second fix to the FP handling? -- Alex Bennée Virtualisation Tech Lead @ Linaro
