Re: [PATCH 05/14] block: Convert bdrv_refresh_total_sectors() to co_wrapper_mixed

[Vladimir Sementsov-Ogievskiy]

On 12/13/22 11:53, Kevin Wolf wrote:

--- a/include/block/block_int-common.h
+++ b/include/block/block_int-common.h
@@ -684,7 +684,7 @@ struct BlockDriver {
      int coroutine_fn (*bdrv_co_truncate)(BlockDriverState *bs, int64_t offset,
                                           bool exact, PreallocMode prealloc,
                                           BdrvRequestFlags flags, Error 
**errp);
-    int64_t (*bdrv_getlength)(BlockDriverState *bs);
+    int64_t coroutine_fn (*bdrv_getlength)(BlockDriverState *bs);

Like in 02 and 03, realizations of the callback are not marked coroutine_fn. [*]

(do we want to reanme it to _co_ ? This also simplifies review, in a way to 
check [*])

--
Best regards,
Vladimir