> On Dec 15, 2022, at 4:56 AM, Cédric Le Goater <[email protected]> wrote:
> 
> On 11/9/22 00:13, John Johnson wrote:
>> 
>> +    DEFINE_PROP_UINT32("x-msg-timeout", VFIOUserPCIDevice, wait_time, 0),
> 
> I see that patch 9 introduced :
> 
> +static int wait_time = 5000;   /* wait up to 5 sec for busy servers */
> 
> May be use a define instead and assign  "x-msg-timeout" to this default
> value.
> 
> how do you plan to use the "x-msg-timeout" property ?
> 

        It was originally used to empirically discover a value that wouldn't
timeout with the device servers we’re using.  I kept in case new devices with
longer response times are encountered.

                                                        JJ

Reply via email to