On 11/29/11 20:52, Stefan Hajnoczi wrote:
On Tue, Nov 29, 2011 at 7:55 PM, Benjamin<[email protected]> wrote:
Signed-off-by: Benjamin<[email protected]>
---
net.c | 6 ++++-
net/socket.c | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
qemu-options.hx | 2 +
3 files changed, 78 insertions(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi<[email protected]>
+ s = net_socket_fd_init(vlan, model, name, fd, 0);
+ if (!s) {
+ return -1;
+ }
I'll add a TODO to my list about net_socket_fd_init(). It does not
consistently take ownership of fd. It may return NULL without closing
it, but then again it might close it on error in another code path :(.
Don't worry about this for now.
Stefan
Me again, is it supposed to take that long before the patch is
accepted? Did I forget something?
Regards,
Benjamin
