On 11/30/22 05:26, Philippe Mathieu-Daudé wrote:
Trivial cleanup (99% mechanical) suggested by rth:
the tcg_target_[u]long type is redundant with [u]intptr_t.
Ah, no, what I said was that much of the usage in tcg-op.h should be either ptrdiff_t or
intptr_t. In particular, e.g.
static inline void tcg_gen_ld_i32(TCGv_i32 ret, TCGv_ptr arg2,
tcg_target_long offset)
should change, because @offset is an addend to a host pointer. In this case ptrdiff_t
seems more descriptive than intptr_t.
Generalized replacement is wrong. In particular it would break x32 (ilp32 on x86_64)...
not that I've done any testing of that in the past few releases, and qemu is exactly the
wrong sort of application to be skimping on host pointer width.
r~
