On Tue, Nov 29, 2022 at 12:04:04PM +0800, Zhenzhong Duan wrote: > The value of "Sample Pages" is confusing in mode other than page-sampling. > See below: > > (qemu) calc_dirty_rate -b 10 520 > (qemu) info dirty_rate > Status: measuring > Start Time: 11646834 (ms) > Sample Pages: 520 (per GB) > Period: 10 (sec) > Mode: dirty-bitmap > Dirty rate: (not ready) > > (qemu) info dirty_rate > Status: measured > Start Time: 11646834 (ms) > Sample Pages: 0 (per GB) > Period: 10 (sec) > Mode: dirty-bitmap > Dirty rate: 2 (MB/s) > > While it's totally useless in dirty-ring and dirty-bitmap mode, fix to > show it only in page-sampling mode. > > Signed-off-by: Zhenzhong Duan <[email protected]>
Reviewed-by: Peter Xu <[email protected]> -- Peter Xu
