On Sun, 23 Oct 2022 at 16:37, <[email protected]> wrote:
>
> From: Tobias Röhmel <[email protected]>
>
> RVBAR shadows RVBAR_ELx where x is the highest exception
> level if the highest EL is not EL3. This patch also allows
> ARMv8 CPUs to change the reset address with
> the rvbar property.
>
> Signed-off-by: Tobias Röhmel <[email protected]>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 3c517356e1..2e9e420d4e 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -7768,8 +7768,8 @@ void register_cp_regs_for_features(ARMCPU *cpu)
> if (!arm_feature(env, ARM_FEATURE_EL3) &&
> !arm_feature(env, ARM_FEATURE_EL2)) {
> ARMCPRegInfo rvbar = {
> - .name = "RVBAR_EL1", .state = ARM_CP_STATE_AA64,
> - .opc0 = 3, .opc1 = 0, .crn = 12, .crm = 0, .opc2 = 1,
> + .name = "RVBAR_EL1", .state = ARM_CP_STATE_BOTH,
> + .opc0 = 3, .cp = 15, .opc1 = 0, .crn = 12, .crm = 0, .opc2 =
> 1,
You don't need to specify .cp for a STATE_BOTH register: 15
is the default.
Otherwise
Reviewed-by: Peter Maydell <[email protected]>
thanks
-- PMM
