On Oct 21 14:59, Daniel Wagner wrote: > On Tue, Oct 18, 2022 at 10:15:57AM +0200, Daniel Wagner wrote: > > On Mon, Oct 10, 2022 at 07:15:08PM +0200, Klaus Jensen wrote: > > > This is all upstream. Namespaces with 'shared=on' *should* all be > > > automatically attached to any hotplugged controller devices. > > > > > > With what setup is this not working for you? > > > > Ah okay, I missed the 'shared=on' bit. Let me try again. > > Nope, that's not enough. Maybe my setup is not okay? > > <qemu:commandline> > <qemu:arg value='-device'/> > <qemu:arg value='pcie-root-port,id=root,slot=1'/> > </qemu:commandline> > > qemu-monitor-command tw0 --hmp drive_add 0 > if=none,file=/tmp/nvme1.qcow2,format=qcow2,id=nvme1 > qemu-monitor-command tw0 --hmp device_add > nvme,id=nvme1,serial=nvme-1,bus=root > qemu-monitor-command tw0 --hmp device_add > nvme-ns,drive=nvme1,nsid=1,shared=on > Error: Bus 'nvme1' does not support hotplugging > > With the patch below the hotplugging works. >
Looks like you are not configuring a subsystem device (nvme-subsys) and attaching the nvme controller to it.
signature.asc
Description: PGP signature
