On 27/10/2022 22.42, Christian Schoenebeck wrote:
On Thursday, October 27, 2022 7:37:07 PM CEST Stefan Hajnoczi wrote:
On Thu, 27 Oct 2022 at 12:38, Christian Schoenebeck
<[email protected]> wrote:
On Thursday, October 27, 2022 5:53:47 PM CEST Thomas Huth wrote:
On 24/10/2022 12.54, Christian Schoenebeck wrote:
The following changes since commit 0529245488865038344d64fff7ee05864d3d17f6:
Merge tag 'pull-target-arm-20221020' of
https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-10-20
14:36:12 -0400)
are available in the Git repository at:
https://github.com/cschoenebeck/qemu.git tags/pull-9p-20221024
for you to fetch changes up to 3ce77865bf813f313cf79c00fd951bfc95a50165:
tests/9p: remove unnecessary g_strdup() calls (2022-10-24 12:24:32 +0200)
----------------------------------------------------------------
9pfs: performance, Windows host prep, tests restructure
* Highlight of this PR is Linus Heckemann's GHashTable patch which
brings massive general performance improvements of 9p server
somewhere between factor 6 .. 12.
* Bin Meng's g_mkdir patch is a preparatory patch for upcoming
Windows host support of 9p server.
* The rest of the patches in this PR are 9p test code restructuring
and refactoring changes to improve readability and to ease
maintenance of 9p test code on the long-term.
Hi Christian,
I think this PR broke the FreeBSD CI jobs:
https://gitlab.com/qemu-project/qemu/-/jobs/3219611457#L3116
https://gitlab.com/qemu-project/qemu/-/jobs/3219611460#L3372
Could you please have a look?
Thanks!
Thomas
I try, but will certainly take some days, especially as I currently don't have
a BSD installation at hand to try the changes.
QEMU has the automation to run FreeBSD builds locally (in a VM):
$ make vm-build-freebsd
Not sure if that FreeBSD environment matches the one in Cirrus CI
though. If they are different then maybe it won't reproduce locally.
Something must be different, because e750a7ace492f0b450653d4ad368a77d6f660fb8
compiles fine locally with `make vm-build-freebsd` and all tests pass, too.
Ideas?
You've got to --enable-werror to make it fail, try something like this:
make vm-build-freebsd J=8 TARGET_LIST=x86_64-softmmu \
BUILD_TARGET=check-build DEBUG=1 \
EXTRA_CONFIGURE_OPTS="--enable-werror"
HTH,
Thomas
