On 23.10.22 21:58, Julia Suvorova wrote:
In the ACPI specification [1], the 'unarmed' bit is set when a device cannot accept a persistent write. This means that when a memdev is read-only, the 'unarmed' flag must be turned on. The logic is correct, just changing the error message.[1] ACPI NFIT NVDIMM Region Mapping Structure "NVDIMM State Flags" Bit 3 Fixes: dbd730e859 ("nvdimm: check -object memory-backend-file, readonly=on option") Signed-off-by: Julia Suvorova <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Pankaj Gupta <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Acked-by: David Hildenbrand <[email protected]> --- v2: * enquote 'on' [Philippe] hw/mem/nvdimm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c index 7c7d777781..31080c22c9 100644 --- a/hw/mem/nvdimm.c +++ b/hw/mem/nvdimm.c @@ -149,7 +149,7 @@ static void nvdimm_prepare_memory_region(NVDIMMDevice *nvdimm, Error **errp) if (!nvdimm->unarmed && memory_region_is_rom(mr)) { HostMemoryBackend *hostmem = dimm->hostmem;- error_setg(errp, "'unarmed' property must be off since memdev %s "+ error_setg(errp, "'unarmed' property must be 'on' since memdev %s " "is read-only", object_get_canonical_path_component(OBJECT(hostmem))); return;
Thanks, queued to https://github.com/davidhildenbrand/qemu.git mem-next -- Thanks, David / dhildenb
