On Wed, Oct 19, 2022 at 9:01 PM Alex Bennée <[email protected]> wrote: > > > Ani Sinha <[email protected]> writes: > > > PSS tests in acpi test suite seems to be failing in biosbits. This is > > because > > the test is unable to find PSS support in QEMU bios. Let us disable > > them for now so that make check does not fail. We can fix the tests and > > re-enable them later. > > > > Example failure: > > > > ---- ACPI _PSS (Pstate) table conformance tests ---- > > [assert] _PSS must exist FAIL > > \_SB_.CPUS.C000 > > No _PSS exists > > Summary: 1 passed, 1 failed > > ---- ACPI _PSS (Pstate) runtime tests ---- > > [assert] _PSS must exist FAIL > > \_SB_.CPUS.C000 > > No _PSS exists > > Summary: 0 passed, 1 failed > > > > Cc: Daniel P. Berrangé <[email protected]> > > Cc: Paolo Bonzini <[email protected]> > > Cc: Maydell Peter <[email protected]> > > Cc: John Snow <[email protected]> > > Cc: Thomas Huth <[email protected]> > > Cc: Alex Bennée <[email protected]> > > Cc: Igor Mammedov <[email protected]> > > Cc: Michael Tsirkin <[email protected]> > > Signed-off-by: Ani Sinha <[email protected]> > > --- > > tests/avocado/acpi-bits/bits-tests/testacpi.py2 | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tests/avocado/acpi-bits/bits-tests/testacpi.py2 > > b/tests/avocado/acpi-bits/bits-tests/testacpi.py2 > > index 18dc818d62..f818a9cce6 100644 > > --- a/tests/avocado/acpi-bits/bits-tests/testacpi.py2 > > +++ b/tests/avocado/acpi-bits/bits-tests/testacpi.py2 > > @@ -40,8 +40,8 @@ import time > > > > def register_tests(): > > testsuite.add_test("ACPI _MAT (Multiple APIC Table Entry) under > > Processor objects", test_mat, submenu="ACPI Tests") > > - testsuite.add_test("ACPI _PSS (Pstate) table conformance tests", > > test_pss, submenu="ACPI Tests") > > - testsuite.add_test("ACPI _PSS (Pstate) runtime tests", test_pstates, > > submenu="ACPI Tests") > > +# testsuite.add_test("ACPI _PSS (Pstate) table conformance tests", > > test_pss, submenu="ACPI Tests") > > +# testsuite.add_test("ACPI _PSS (Pstate) runtime tests", test_pstates, > > submenu="ACPI Tests") > > testsuite.add_test("ACPI DSDT (Differentiated System Description > > Table)", test_dsdt, submenu="ACPI Tests") > > testsuite.add_test("ACPI FACP (Fixed ACPI Description Table)", > > test_facp, submenu="ACPI Tests") > > testsuite.add_test("ACPI HPET (High Precision Event Timer Table)", > > test_hpet, submenu="ACPI Tests") > > I think this breaks bisection so should probably be included in the > commit that add the test with a comment in the commit message.
Ah I see. The addition and the disabling has to be atomic so that there are no test failures if addition patch is cherry-picked and not the patch that disabled the tests. Hmm.
