Hi, > Anyway, we need to support different PCI sub-vendor IDs > in order to be compliant with Microsoft WHQL rules. Though, > actually, at my opinion this requirement has nothing in > common with libvirt people. The most convenient way > here would be to specify these properties within vendor > machine types and this place is a perfect match as any > respectable has its own machine type.
Yes, when wiring this up via vendor machine types there is no need to touch libvirt. > I would also think that PCI level is not a good place for that > as we would not be able to apply this change blindly as at > PCI level this change would be too global and the same > was initially noted by Michael Tsirkin here > > https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg04384.html > > Any thoughts? > What should we do with the original patch from Ben? We > still need an ability to expose vendor identity in QXL/virtio... I'd suggest to add properties to PCIDevice then. That will allow to override the default subsystem id for both specific pci devices and all pci devices. take care, Gerd
