On Sat, Oct 01, 2022 at 11:34:20PM +0200, Andreas Schwab wrote: > On Aug 02 2022, Daniel P. Berrangé wrote: > > > This patch removes linux/fs.h, meaning we have to define > > various FS_IOC constants that are now unavailable. > > This breaks a lot of ioctl emulations, as it lacks their definitions:
Urgh, very sorry about that. I of course tested it compiled, but not realizing a bunch of ioctls were #ifdef'd, so we ended up silently disabling them. > > #define BLKGETSIZE64 _IOR(0x12,114,size_t) > #define BLKDISCARD _IO(0x12,119) > #define BLKIOMIN _IO(0x12,120) > #define BLKIOOPT _IO(0x12,121) > #define BLKALIGNOFF _IO(0x12,122) > #define BLKPBSZGET _IO(0x12,123) > #define BLKDISCARDZEROES _IO(0x12,124) > #define BLKSECDISCARD _IO(0x12,125) > #define BLKROTATIONAL _IO(0x12,126) > #define BLKZEROOUT _IO(0x12,127) > > #define FIBMAP _IO(0x00,1) > #define FICLONE _IOW(0x94, 9, int) > #define FIGETBSZ _IO(0x00,2) With the exception of FICLONE from 2015, all the others here have exited in Linux header since 2012. Given that length of time there's no reason for us to conditionalize their usage. We want to see failure if they're unexpectedly missing from headers. I'll prepare a patch to fix all this. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
