Ping! This series has been reviewed. I can take it via target-arm.next if you'd prefer.
thanks -- PMM On Thu, 18 Aug 2022 at 14:54, Peter Maydell <[email protected]> wrote: > > This patchset fixes a Coverity nit relating to the > pci_set_*_by_mask() helper functions, where we might shift off the > end of a variable if the caller passes in a bogus mask argument. > Patch 2 is the coverity fix (adding an assert() to help Coverity > out a bit and to catch potential future actual bugs). Patch 1 > removes the _get_ versions of the functions, because they've been > in the tree for a decade and never had any callers at any point > in those 10 years :-) > > This is only de-confusing Coverity, so this is definitely > 7.2 material at this point. > > All patches already have a reviewed-by tag; only change > v1->v2 is removing a couple of unnecessary mask operations > in patch 2. > > thanks > -- PMM > > Peter Maydell (2): > pci: Remove unused pci_get_*_by_mask() functions > pci: Sanity check mask argument to pci_set_*_by_mask() > > include/hw/pci/pci.h | 48 +++++++++++++++----------------------------- > 1 file changed, 16 insertions(+), 32 deletions(-)
