Re: [PATCH] target/i386: fix INSERTQ implementation

[Richard Henderson]

On 9/18/22 09:56, Paolo Bonzini wrote:

+                else {
+                    if (mod != 3) {
+                        gen_lea_modrm(env, s, modrm);
+                        op2_offset = offsetof(CPUX86State, xmm_t0);
+                        gen_ldq_env_A0(s, offsetof(CPUX86State, 
xmm_t0.ZMM_D(0)));

INSERTQ doesn't support a memory source.  The two forms are

INSERTQ xmm1, xmm2, imm8, imm8
INSERTQ xmm1, xmm2


r~