Re: [PATCH 07/18] i386: Rewrite simple integer vector helpers

[Paolo Bonzini]

On 8/26/22 02:01, Richard Henderson wrote:

-#if SHIFT == 0
-SSE_HELPER_W(helper_pmulhrw, FMULHRW)
-#endif
  SSE_HELPER_W(helper_pmulhuw, FMULHUW)
  SSE_HELPER_W(helper_pmulhw, FMULHW)
+#if SHIFT == 0
+void glue(helper_pmulhrw, SUFFIX)(CPUX86State *env, Reg *d, Reg *s)
+{
+    d->W(0) = FMULHRW(d->W(0), s->W(0));
+    d->W(1) = FMULHRW(d->W(1), s->W(1));
+    d->W(2) = FMULHRW(d->W(2), s->W(2));
+    d->W(3) = FMULHRW(d->W(3), s->W(3));
+}
+#endif

Why?

Because this is actually a 3DNow instruction so it doesn't get the 
3-operand treatment later.  But I can defer the change to the next part 
of the series.

Paolo