* Bin Meng ([email protected]) wrote:
> From: Xuzhou Cheng <[email protected]>
>
> Make sure QEMU process "to" is killed before launching another target
> for migration in the test_multifd_tcp_cancel case.
>
> Signed-off-by: Xuzhou Cheng <[email protected]>
> Signed-off-by: Bin Meng <[email protected]>
> ---
>
> tests/qtest/migration-test.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 125d48d855..18ec079abf 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -2132,6 +2132,10 @@ static void test_multifd_tcp_cancel(void)
> wait_for_migration_pass(from);
>
> migrate_cancel(from);
> + /* Make sure QEMU process "to" is killed */
> + if (qtest_probe_child(to)) {
> + qtest_kill_qemu(to);
> + }
I'm not sure that's safe - what happens if the qemu exits between the
probe and kill?
Dave
> args = (MigrateStart){
> .only_target = true,
> --
> 2.34.1
>
--
Dr. David Alan Gilbert / [email protected] / Manchester, UK
