Richard Henderson <[email protected]> writes:
> This can be made redundant with result->page_size, by moving > the basic set of page_size from get_phys_addr_pmsav8. We still > need to overwrite page_size when v8m_security_lookup signals > a subpage. > > Signed-off-by: Richard Henderson <[email protected]> > --- <snip> > > ret = pmsav8_mpu_lookup(env, address, access_type, mmu_idx, > - result, &mpu_is_subpage, fi, NULL); > - result->page_size = > - sattrs.subpage || mpu_is_subpage ? 1 : TARGET_PAGE_SIZE; > + result, fi, NULL); > + if (sattrs.subpage) { > + result->page_size = 1; > + } We should probably document the meaning of page_size == 1 in the comments for the definition of GetPhysAddrResult. > return ret; > } -- Alex Bennée
